Skip to content

Support updating label and origin domain of publish #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xzhang1 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support updating label and origin domain of publish #1484

xzhang1 wants to merge 1 commit into from
+84 −4

Conversation

@xzhang1
Copy link

@xzhang1 xzhang1 commented Aug 21, 2025 •
edited
Loading

Fixes #1007

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this Aug 27, 2025
@neolynx neolynx requested a review from a team August 27, 2025 21:43
@neolynx neolynx added this to the 1.6.3 milestone Aug 27, 2025
neolynx
neolynx reviewed Aug 30, 2025
View reviewed changes
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thanks !

wonder if we should add some tests, making sure the values are respected...

@xzhang1
Support updating label and origin domain of publish
2d0d211 
Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com>
@xzhang1
Copy link
Author

xzhang1 commented Sep 2, 2025 •
edited
Loading

@neolynx Thanks for your kindly reminds. Updated the patch and make three test cases for it.

===
Support update "label" and "origin" of aptly publish on:

  1. Command aptly publish update
    Add new test case "t06_publish/PublishUpdate19Test"

  2. REST API: api.POST("/publish/:prefix/:distribution/update", apiPublishUpdate)
    Modify test case "t12_api/PublishUpdateSourcesAPITestRepo"

  3. REST API: api.PUT("/publish/:prefix/:distribution", apiPublishUpdateSwitch)
    Modify test case "t12_api/PublishSwitchAPITestRepo"

@xzhang1 xzhang1 requested a review from neolynx September 5, 2025 07:44
@xzhang1
Copy link
Author

xzhang1 commented Oct 27, 2025

@neolynx Is there anything else supplementary I need to do? Additionally, is there any possibility of adding this patch to Debian:trixie? One of our projects is built on Debian:trixie, and it would be beneficial to our project if this patch could be added to Debian:trixie.

@neolynx neolynx requested a review from a team January 4, 2026 12:59
@neolynx neolynx mentioned this pull request Jan 4, 2026
Draft
@neolynx neolynx added the increase coverage The PR lacks test coverage label Jan 4, 2026
@neolynx
Copy link
Member

neolynx commented Jan 5, 2026 •
edited
Loading

we need a system test to cover the changes in cmd/publish_update.go

maybe we can modify an existing one, or add a new one in system/t06_publish/update.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neolynx neolynx Awaiting requested review from neolynx

At least 1 approving review is required to merge this pull request.

Assignees

@neolynx neolynx

Labels

increase coverage The PR lacks test coverage

Projects

None yet

Milestone

1.6.3

Development

Successfully merging this pull request may close these issues.

Add option to change settings of publish without dropping?

2 participants

@xzhang1 @neolynx